fix(humio_metrics sink): dont use flatten for logs config fields #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
jszwedko
approved these changes
Nov 9, 2020
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…tordotdev#4924) * Humio metrics cant use flatten as the alias field doesn't work Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fix fmt Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4903
There is a bug in Serde (here) whereby if you flatten fields from another struct it will not alias any fields from that struct.
So, I have had to copy the field from the Humio logs config rather that flatten them. The code is not as elegant, but until Serde fix that issue, there isn't much else to do. By the sounds of it, it is quite a hard bug to fix.