-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add real world topology benchmark #6274
Conversation
d7b4cc1
to
7297adf
Compare
677f30b
to
718f7fc
Compare
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
718f7fc
to
71fda52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one note about the input generation, but otherwise this looks good to me!
I'm curious to see if it shows the regression on the lookup PR.
Signed-off-by: MOZGIII <mike-n@narod.ru>
I propose that we merge this into |
Sounds good! |
Closes #5946.
To do:
test against the enhancement: Use new Lookup accessors on LogEvents and entire internal API. #5374 to ensure the performance difference is capturedwe'll merge this one, and rebase enhancement: Use new Lookup accessors on LogEvents and entire internal API. #5374 over to have it run at CI