Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add real world topology benchmark #6274

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Jan 28, 2021

Closes #5946.

To do:

@MOZGIII MOZGIII force-pushed the topology-real-world-bench branch 2 times, most recently from d7b4cc1 to 7297adf Compare January 29, 2021 06:46
@jszwedko jszwedko mentioned this pull request Feb 1, 2021
4 tasks
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
@MOZGIII MOZGIII marked this pull request as ready for review February 3, 2021 17:08
@MOZGIII MOZGIII requested review from a team, lukesteensen and jszwedko and removed request for a team and lukesteensen February 3, 2021 17:08
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note about the input generation, but otherwise this looks good to me!

I'm curious to see if it shows the regression on the lookup PR.

benches/topology.rs Outdated Show resolved Hide resolved
Signed-off-by: MOZGIII <mike-n@narod.ru>
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Feb 4, 2021

I'm curious to see if it shows the regression on the lookup PR.

I propose that we merge this into master, and then into the lookup PR from there - so that we run the diffs via CI.

@jszwedko
Copy link
Member

jszwedko commented Feb 4, 2021

I'm curious to see if it shows the regression on the lookup PR.

I propose that we merge this into master, and then into the lookup PR from there - so that we run the diffs via CI.

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add topology level benchmarks that do more event manipulation
2 participants