enhancement(remap): add match_any function #7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/vrl/stdlib/src/match_any.rs
Outdated
| Parameter { | ||
| keyword: "patterns", | ||
| kind: kind::ARRAY, | ||
| required: false, |
There was a problem hiding this comment.
Why would this not be required?
There was a problem hiding this comment.
Good catch! It should definitely be required. Seems like this was somehow fixed when rebasing.
There was a problem hiding this comment.
Doh, I was looking at somewhere else. Will push a fix now.
StephenWakely
approved these changes
May 26, 2021
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
jszwedko
approved these changes
May 27, 2021
|
I wonder if we should add a follow up issues to convert successive |
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
This was something I looked into first, but it seemed pretty non-trivial. I'll at least open an issue around adding that kind of optimization pass to the VRL compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently built on top of #7250 to take advantage of some of @jszwedko additions there.
It's also not documented and has oneunwrapthat needs removed, but I'm opening it in this state to get some feedback since it's my first real work with VRL.The goal here is to optimize the case of checking against multiple regexes. Instead of
match(.foo, ...) || match(.foo, ...) || ..., you can simply pass an array of patterns that are compiled to aRegexSetand checked efficiently in one pass. This is also more ergonomic than asking users to combine patterns manually.