fix(log_to_metric transform): Drop events where field is null
#7487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the documented behavior but we were not honoring it. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
requested review from
spencergilbert,
a team and
pablosichert
and removed request for
a team
spencergilbert
approved these changes
May 26, 2021
| @@ -3,6 +3,26 @@ use crate::template::TemplateParseError; | |||
| use metrics::counter; | |||
| use std::num::ParseFloatError; | |||
|
|
|||
| pub(crate) struct LogToMetricFieldNull<'a> { | |||
There was a problem hiding this comment.
I feel like I've seen these generally ordered in the file alphabetically, if that's a "standard" we should move this below LogToMetricFieldNotFound
There was a problem hiding this comment.
Hmm, interesting, I certainly haven't been ordering them that way. I think if they are that is probably incidental.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the documented behavior but we were not honoring it.
Signed-off-by: Jesse Szwedko jesse@szwedko.me