chore(deps): bump tokio from 1.6.1 to 1.6.2 #7858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.6.1 to 1.6.2. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.6.1...tokio-1.6.2) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Given that this tokio upgrade fixes the imprecision https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3852 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
dependabot
bot
requested review from
a team and
vladimir-dd
and removed request for
a team
|
@bruceg looks like |
|
Yeah, I was seeing that. 😮 |
|
A newer version of tokio exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
jszwedko
approved these changes
Jun 16, 2021
|
Hmm, it looks like this upgrade is causing The diff between 1.6.1, which works, and 1.6.2 is pretty small so hopefully it won't be too hard to track down. tokio-rs/tokio@tokio-1.6.1...tokio-1.6.2 |
This gets rid of the blocking behavior I was seeing, but ends up
breaking, at least one of, the tests:
```
Running test in "tests/data/adaptive-concurrency/constant-link.toml"
Comparison failed: controller observed_rtt max = 0.103; maximum = 0.102
Comparison failed: controller observed_rtt mean = 0.10200030637254906; maximum = 0.102
Comparison failed: controller averaged_rtt max = 0.10203225806451613; maximum = 0.102
Comparison failed: controller averaged_rtt mean = 0.10200104058272637; maximum = 0.102
thread 'sinks::util::adaptive_concurrency::tests::all_tests' panicked at 'TestResults {
stats: Statistics {
completed: 500,
in_flight: LevelTimeHistogram {
level: 0,
histogram: TimeHistogram {
histogram: Histogram {
totals: [
0.0,
0.204,
0.102,
0.203,
0.103,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
],
},
last_time: Some(
Instant {
t: 587447403828567,
},
),
},
},
rate: Some(
HistogramStats {
min: 1,
max: 246,
mode: 243,
total: 3.365999999999999,
mean: 111.03713606654783,
},
),
requests: 223,
},
cstats: ControllerStatistics {
in_flight: TimeHistogram {
histogram: Histogram {
totals: [
0.0,
0.204,
0.102,
0.203,
0.103,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
],
},
last_time: Some(
Instant {
t: 587447403828567,
},
),
},
concurrency_limit: TimeHistogram {
histogram: Histogram {
totals: [
0.0,
0.0,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
0.102,
],
},
last_time: Some(
Instant {
t: 587447403828567,
},
),
},
observed_rtt: TimeWeightedSum {
sum: WeightedSum {
total: 0.3329290000000001,
weights: 3.2639999999999993,
min: Some(
0.102,
),
max: Some(
0.103,
),
},
last_observation: Some(
Instant {
t: 587447403828567,
},
),
},
averaged_rtt: TimeWeightedSum {
sum: WeightedSum {
total: 0.3225272903225807,
weights: 3.1619999999999995,
min: Some(
0.102,
),
max: Some(
0.10203225806451613,
),
},
last_observation: Some(
Instant {
t: 587447403828567,
},
),
},
},
}', src/sinks/util/adaptive_concurrency/tests.rs:608:5
```
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
|
I pushed 7be7347 which fixes the issue with the tests hanging but ends up causing a test failure: |
…kio-1.6.2 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
bruceg
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps tokio from 1.6.1 to 1.6.2.
Release notes
Sourced from tokio's releases.
Commits
dfe4013chore: prepare Tokio 1.6.2 release (#3859)18779aatime: fix time::advance() with sub-ms durations (#3852)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)