enhancement(prometheus_exporter sink): expire metrics #9769
Conversation
Closes #5867 Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 0dfa3ed 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6182e39bf0c21c00078f2835 |
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
I do agree it'd make more sense for this to live on the value side of the map, but it's awkward right now because the value itself lives in the key. I can move it in that direction, but I think my thought process was mostly that this is part of the "metrics entry". The whole thing would make more sense if we did something like |
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
|
@bruceg I switched over to the approach you suggested and I agree that's probably the way to go for now. |
src/sinks/prometheus/exporter.rs
Outdated
| (entry, metadata) | ||
| }) | ||
| .filter(|(_metric, metadata)| { | ||
| metadata.updated_at.elapsed().as_secs() < self.config.flush_period_secs |
There was a problem hiding this comment.
This could use an Instant::now computed outside of the filter and start.duration_since(metadata.updated_at).as_secs() here.
|
|
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
This field took on more responsibility in #9769. This PR updates the doc to reflect its new semantics. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
* docs(prometheus_exporter sink): Update `flush_period_secs` docs This field took on more responsibility in #9769. This PR updates the doc to reflect its new semantics. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Closes #5867