-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): Add ingress_upstreaminfo
log format to parse_nginx_log
function
#193
Conversation
81179b4
to
98f06cd
Compare
98f06cd
to
ad5054c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good. Just a few changes requested to the type definition.
Also, please add a line to the CHANGELOG.md
with a summary of these changes.
That seems reasonable to me, although this would be a breaking change. Curious if anyone else has thoughts here. I think some field names were chosen initially to match Vector conventions (such as |
I'd agree with matching the "upstream" naming schemes 👍 |
7d0c2f7
to
e2b7103
Compare
Thanks for the review, pushed all the requested changes |
e2b7103
to
7cd3d9c
Compare
7cd3d9c
to
61af420
Compare
Base branch was modified
Fixes #5
Also, what do you guys think on renaming parsed fields like they are named in Nginx docs here?
I would stick with that nginx's internal fields naming "convention", it's so close to RFCs at least.
If you are agree with this, I would make another PR to rename fields in "combined" format too