chore: remove stdlib function features #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
approved these changes
May 22, 2023
scMarkus
pushed a commit
to scMarkus/vrl
that referenced
this pull request
May 27, 2023
itkovian
pushed a commit
to itkovian/vrl
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously every stdlib function had a feature flag to enable/disable it. This allowed only compiling functions you were actually interested in using. However, this requires significant CI time (~90 mins) for every PR to check, and it only saves a few seconds on a local debug build by disabling some of the functions. We decided it's not really worth it, and we don't currently have a great use-case for being able to compile-time disable functions. You can still decide at runtime which stdlib functions are enabled.
The
only_fieldsfunction was also removed entirely. This was a deprecated function that was never used (the feature flag didn't even exist anymore).