Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#510 Add support for TinyMCE translations #603

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

mlutfy
Copy link
Contributor

@mlutfy mlutfy commented Jul 5, 2023

Adds support for translating the TinyMCE editor that is part of Mosaico:

image

Related:

Ideally we would bundle the translations. Maybe during the build script?

Note that the code is a bit meh with handling the locale codes, because for some reason some use the long-form xx_YY and some use the short form, and then it just won't support some locales such as fr_CA, even if the translation is there.

Once the PR is merged, to add the translations, they must be copied to either the short of long form, such as:

  • packages/mosaico/dist/tinymce/langs/fr_FR.js
  • packages/mosaico/dist/tinymce/langs/fr.js

.. depending on the locale name listed here: https://www.tiny.cloud/docs-4x/configure/localization/

for some locales, we might need in the future to adapt the getTinymceLocale function to support more language variants (for now it only supports fr_CA).

Unverified

This user has not yet uploaded their public signing key.
@mlutfy
Copy link
Contributor Author

mlutfy commented Jul 5, 2023

cc @allinappliadmin @UshaMakoa @samuelsov

@allinappliadmin
Copy link

oh yeahhhh! I had opened this issue: #510

@mattwire mattwire merged commit 16eebe0 into veda-consulting-company:2.x Jul 31, 2023
@allinappliadmin
Copy link

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants