issue#510 Add support for TinyMCE translations #603
Merged
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for translating the TinyMCE editor that is part of Mosaico:
Related:
Ideally we would bundle the translations. Maybe during the build script?
Note that the code is a bit meh with handling the locale codes, because for some reason some use the long-form
xx_YY
and some use the short form, and then it just won't support some locales such asfr_CA
, even if the translation is there.Once the PR is merged, to add the translations, they must be copied to either the short of long form, such as:
packages/mosaico/dist/tinymce/langs/fr_FR.js
packages/mosaico/dist/tinymce/langs/fr.js
.. depending on the locale name listed here: https://www.tiny.cloud/docs-4x/configure/localization/
for some locales, we might need in the future to adapt the
getTinymceLocale
function to support more language variants (for now it only supportsfr_CA
).