[Utils] Streamline utils_saturate_vector_2d()
#460
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the worst case, when saturation is needed, will still take the same amount of time. Also, sqrtf is quite fast on the FPU. For optimizations like this one it would be good to set up a way to profile how much difference they make. Maybe this can be done by running a test on the STM32 with some build option and plot the result in VESC Tool. |
There was no need to do the `sqrt()` unless the absolute magnitude is exceeded.
kubark42
force-pushed
the
util_saturate_vector_optimize
branch
from
3e78449
to
baf92a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no need to do the
sqrt()unless the absolute magnitude is exceeded.Passes unit tests but shouldn't be merged until #459 is merged.