Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for M365 Dashboard Lisp #234

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

1zun4secondary
Copy link

@1zun4secondary 1zun4secondary commented Jun 4, 2022

Features to be added:

  • Add speed modes (double tap on button)
  • Add lock mode with beeping and braking (double press while braking)
  • Add min-speed feature (makes it more secure)
  • Add shutdown feature (turn it off by long press and back on by single tap)
  • Add battery in idle feature
  • Add separate ADC version

Fixes to be done (Probably my own issues because no one else has it):

  • Figure out why 0x64 packets are not being read. (on my setup) (Can be ignored due to the fact that we do not have to receive any 0x64 packets to sent our own 0x64 back)
  • Figure out why button reading is randomly (can be fixed with 470R resistor between 3.3v and RX)

I have read the CLA Document and I hereby sign the CLA
I have read the CLA Document and I hereby sign the CLA

1zun4 added 4 commits May 20, 2022 00:59
added min-speed feature
added show-batt-in-idle feature
improved throttle and brake values
added speed modes on double press (still has to implement rpm limit)
added off and on when pressing long
added lock (double press when braking)
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@1zun4secondary
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@1zun4secondary
Copy link
Author

recheck

@Axel070719
Copy link

I have read the CLA Document and I hereby sign the CLA

@Axel070719
Copy link

Recheck

improved button responsiveness
fixed not turning on by single tap
added beep feedback
pushing while locked will now make beep
(testing ADC override - will add it very soon)
added adc version
fully support speed modes now
cleanup
@1zun4secondary 1zun4secondary marked this pull request as ready for review June 13, 2022 16:15
@1zun4secondary
Copy link
Author

video_2022-06-15_12-15-33_Trim.mp4
video_2022-06-15_12-15-38.mp4
video_2022-06-15_12-15-42.mp4

@1zun4secondary
Copy link
Author

1zun4secondary commented Jul 30, 2022

Hello @vedderb, so far the script has been working great, but after updating my bldc firmware it sstarted stuttering when using set-current

The issue is most likely caused by the commit: m365fw/vesc_fw@360f0ef

Fixed by vedderb/bldc#514

Added throttle deadzone
Added brake deadzone
Optimized throttle and brake values
Added throttle-in and brake-in variables for calibration
Added brake min-speed and fixed noise when pressing brake on 0km/h
Fixed throttle and brake values going over 1 (not really a issue but it is better)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants