Windows resources file / Icon #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed there's no icon included in the app. Also, the Details tab in "Properties" is empty. This commit should fix that. Full disclosure: this hasn't been tested - it's just following the pattern I use for other Qt Windows applications. My apologies if it ends up not working |
|
Rebased to 6.02 beta |
|
Some discussion of this on the discord. |
Icon created using the following command: convert ios/Images.xcassets/AppIcon.appiconset/1024.png -define icon:auto-resize=256,64,48,32,16 res/vesc.ico Signed-off-by: Dado Mista <dadomista@gmail.com>
Signed-off-by: Dado Mista <dadomista@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon created using the following command:
convert ios/Images.xcassets/AppIcon.appiconset/1024.png -define icon:auto-resize=256,64,48,32,16 res/vesc.ico
Signed-off-by: Dado Mista dadomista@gmail.com