Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable HFI when stopped in duty cycle and speed modes #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgeek
Copy link

@lgeek lgeek commented Jun 13, 2020

This introduces the HFI "Min ERPM with no input" option for firmware 5.02.
This option dynamically disables HFI in the duty cycle or speed modes
when 0 duty cycle / speed is commanded and the ERPM of the motor is lower
than the set value.

Matching firmware pull request here: vedderb/bldc#183

This introduces the HFI "Min ERPM with no input" option for firmware 5.02.
This option dynamically disables HFI in the duty cycle or speed modes
when 0 duty cycle / speed is commanded and the ERPM of the motor is lower
than the set value.
@Teslafly
Copy link
Contributor

Teslafly commented Nov 6, 2022

it looks like there is a lot of extra changes in the files for this pr than just adding the required settings.

@lgeek
Copy link
Author

lgeek commented Nov 6, 2022

@Teslafly Have you done a diff against 5.01 to see what was actually changed? It's not my fault that VESC tool needs the full XMLs every time the config options available change. Or that @vedderb never bothered to review it in 16 months so it now conflicts with the 5.02 version he released.

@Teslafly
Copy link
Contributor

Teslafly commented Nov 7, 2022

Yeah, the slowness in reviewing pull requests has not been great. I'm trying to help with that by reviewing what I can and bumping things along so they are in a form that's ready to merge. If you still feel this feature is worth adding, Updating this to master and making sure it can be pulled in cleanly would be helpful. (The bldc FW PR too)

github shows a diff of adding completely new config xml's. which is not ideal.

For adding parameters, I would expect only chunks of additions in res/config/6.00/parameters_mcconf.xml (you use the parameter editor to overwrite the current development xml. Then I recommend checking the diff in git to make sure it's reasonable.)

Also, for simple parameters, vedder will sometimes do the parameter adding for you on the vesc_tool side since it's easy for him. Though a pull request is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants