Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using both rails_semantic_logger and activejob-uniqueness together in Rails 6.0.x results in duplicated logs as reported in #73.
The Issue
ActiveJob::Logging::LogSubscriber.attach_to :active_job
.activejob-uniqueness
hasActiveJob::LogSubscriber.attach_to :active_job_uniqueness
.rails_semantic_logger
expects to see one of these but replaces both of these with it's own logger here. And thus duplicating logging.The Solution
This PR ensures that we are creating and attaching a unique log subscriber
ActiveJob::Uniqueness::LogSubscriber
and not creating theActiveJob::LogSubscriber
class in older Rails versions.