Add POSIX setgid/setuid/sticky bit support #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As written, the regex that matches on POSIX directory listings misses
some cases that can appear, especially on more complex systems. These
are cases where the set-user-ID on execution, set-group-ID on execution,
and saved-text (aka setuid, setgid, and "sticky" bits respectively) are
set, typically by a system administrator.
These are quite consistently represented by 's' and 't' in place of the
eXecute bit, and the uppercase alternatives ('S' and 'T') if the eXecute
bit is not set, but the corresponding setuid/setgid/sticky bit is set.
Given that the extant regex does not attempt to validate the ordering
(i.e., xwrxwrxwr is entirely valid), I chose to simply extend the set of
valid values that are accepted in the string of 9 characters following
the initial -/l/d part.
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Lowercase s and lowercase t indicate the presence of a setuid/setgid or sticky bit (respectively), when the execute bit is also present. Their uppercase counterparts indicate the presence of the bit but not the execute bit. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE #58 - Add POSIX setgid/setuid/sticky bit support
Fixes #58
Description
Here, I adjust the
POSIX_LS_REto account fors,S,t, andTin the "pex"-y positions, by adding them to the set of characters we scan for 9 of. Now, the following characters are included in the scan:-rwxsStT, where previously only-rwxswere supported. Off-hand, it appears theswas an attempt to support setuid/setgid, but it did not cover the case where thexbit is not set, which renders as aS.Because this regex did not previously validate for the correct ordering (i.e., refuting strange combos like
rxw), I did not add them in this PR.The
pexparsing closure, which does some simple arithmetic to determine the "pex" value, needed some updates.SandTindicate the presence of a setuid/setgid bit, or a sticky bit, but withoutx. (Ifxis set, then theSinstead is typically reported ass.)So, I added
SandTas exceptions in addition to-. They will be treated the same. With this change, no information is recorded about the setuid/setgid bits, and I don't think the interpretation of them is of great importance at this time given they are interpreted locally by the operating system and they have different meanings.Type of change
Please select relevant options.
Checklist
cargo fmtcargo clippyand reports no warningsAcceptance tests
wait for a project maintainer to fulfill this section...