feat(core::props::Props): add function "get_ref" #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE NUMBER - PULL_REQUEST_TITLE
No Issue
Description
This PR adds a
get_ref
function toProps
to get the searched attribute by reference instead of always cloning likeget
does.Also add tests for all
set
andget
function ofProps
.I did not include a
get_ref_or
function as it is simple enough to just chainprops.get_ref(query).unwrap_or(default)
.Personally, i would recommend to maybe remove the original
get
function in a major version and replace it withget_ref
, this way it is up to the user when to clone the returned value.If it should be removed, i would recommend to put a
#[deprecated]
onget
before it being removed.Type of change
Please select relevant options.
Checklist
cargo fmt
cargo clippy
and reports no warningscfg target_os
)This change would for example allow another clone at stdlib#TextSpan to be removed.
And likely other places too.