Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing autoadded flag, rename table, use createdDate for CoI. #130

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

stephenshank
Copy link
Contributor

  • Do not overwriteautoadded flag on ClusterOI nodes as they are loaded
  • Use clusters_of_interest_table as filename for CoI table
  • Use createdDate instead of getCurrentDate for datetime given to manually added nodes so that they do not appear as older than their associated ClusterOI

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hivtrace-viz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 7:40pm

@stevenweaver
Copy link
Member

stevenweaver commented Mar 6, 2024

Would it be possible to declare which associated Github issues this PR resolves? Either here, by email, or within the Slack channel?

@stephenshank
Copy link
Contributor Author

Certainly. I will try to make this a habit moving forward. Please see latest correspondence on the following issues:

The autoadded flag: https://github.com/veg/hivtrace-secure/issues/180
The use of createdDate to resolve an issue with reporting on manual CoIs: https://github.com/veg/hivtrace-secure/issues/262
The extra quotes in the CoI merge logic: https://github.com/veg/hivtrace-secure/issues/261

@stevenweaver stevenweaver merged commit 9e43eb5 into veg:master Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants