Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctest and run doctests in altair module #3175

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix doctest and run doctests in altair module #3175

merged 2 commits into from
Aug 28, 2023

Conversation

jonmmease
Copy link
Contributor

Closes #3174 by running doctests within the altair module and fixing the failing doctest.

@jonmmease jonmmease mentioned this pull request Aug 28, 2023
Closed
binste
binste approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@binste binste left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for not creating the PR myself, I was not sure if it's just the docstring or something bigger that is wrong.

@jonmmease jonmmease mentioned this pull request Aug 28, 2023
Merged
3 tasks
@jonmmease jonmmease merged commit 17e8d07 into main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binste binste binste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example in docstring of get_inline_table_names does not work. Blocks conda-forge release.
2 participants
@jonmmease @binste