Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding type inference for boolean columns when pyarrow is installed #3210

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

jonmmease
Copy link
Contributor

Closes #3205 by working around pandas-dev/pandas#55332

@binste
Copy link
Contributor

binste commented Sep 30, 2023

py 3.8 tests fail because of the lower-bound pandas version. boolean dtype was introduced in Pandas 1.0. I think we could just skip adding that column in the test in case pandas is < 1.0.

Else, this looks good to me. Thanks for solving it so quickly!

@jonmmease
Copy link
Contributor Author

Thanks for the catch, I'll update the test for 3.8

@jonmmease
Copy link
Contributor Author

Test fixed. merging!

@jonmmease jonmmease merged commit da0de55 into main Sep 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean numpy-backed type fails when pyarrow is installed in env
2 participants