Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update numpy-tooltip-images.rst #3233

Merged
merged 2 commits into from
Mar 16, 2024
Merged

doc: update numpy-tooltip-images.rst #3233

merged 2 commits into from
Mar 16, 2024

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Oct 20, 2023

I see a future warning in Github Action for this page: https://altair-viz.github.io/case_studies/numpy-tooltip-images.html

FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.

My personal preference is to avoid usage of map/applymap/apply lambda functions, but I changed both applymap and apply to map. Not sure if that is right.

Btw, where is this tutorial about? Area of blobs what does that mean?

@mattijn mattijn changed the title Update numpy-tooltip-images.rst doc: update numpy-tooltip-images.rst Oct 20, 2023
@mattijn mattijn requested a review from joelostblom October 20, 2023 07:52
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for missing this PR originally. I added a clarification of what "blob" is referring to (the amorphous objects of white pixels in the images) and will merge when tests are passing

@joelostblom joelostblom merged commit 275ea21 into main Mar 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants