Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: histogram with gradient color #3282

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Dec 13, 2023

This PR adds an example of a histogram with a gradient color. Sometimes it is desirable to emphasise that higher/lower values are more/less favourable (here green/red).

image

@joelostblom
Copy link
Contributor

Pretty =) Could we switch the color scheme to something that is easier to differentiate for people with red-green color vision deficiencies? Maybe redyellowblue or pinkyellowgreen (or really any of the other diverging ones)?

@mattijn
Copy link
Contributor Author

mattijn commented Dec 16, 2023

Thanks for the review @joelostblom! I've changed the example to use the scheme pinkyellowgreen, which is better for red-green color vision deficiencies:
image

Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@joelostblom joelostblom merged commit 4d06175 into main Dec 16, 2023
20 checks passed
@binste
Copy link
Contributor

binste commented Dec 21, 2023

I've just used this in a chart, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants