Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add embed_options to JupyterChart and pass them through in "jupyter" renderer #3304

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Add embed_options to JupyterChart and pass them through in "jupyter" renderer #3304

merged 1 commit into from
Jan 5, 2024

Conversation

jonmmease
Copy link
Contributor

  • Adds an embed_options traitlet to JupyterChart for configuring the Vega Embed options (e.g. whether to display actions).

  • Passes through the active embed_options to JupyterChart when constructed in the "jupyter" renderer.

binste
binste approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works like a charm, thanks Jon!

@binste binste merged commit 4698361 into main Jan 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binste binste binste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmmease @binste