Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve performance of Chart.from_dict #3383

Merged
merged 3 commits into from
Mar 26, 2024
Merged

perf: Improve performance of Chart.from_dict #3383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10b0c0c
improve performance of Chart.from_dict
RobinL Mar 24, 2024
e86add8
ruff
RobinL Mar 24, 2024
4a0f86f
generate utils/schemapi.py automatically
RobinL Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion altair/utils/schemapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@
# class-level _class_is_valid_at_instantiation attribute to False
DEBUG_MODE: bool = True

jsonschema_version_str = importlib_version("jsonschema")


def enable_debug_mode() -> None:
global DEBUG_MODE
Expand Down Expand Up @@ -203,7 +205,6 @@ def _get_json_schema_draft_url(schema: dict) -> str:
def _use_referencing_library() -> bool:
"""In version 4.18.0, the jsonschema package deprecated RefResolver in
favor of the referencing library."""
jsonschema_version_str = importlib_version("jsonschema")
return Version(jsonschema_version_str) >= Version("4.18")


Expand Down
3 changes: 2 additions & 1 deletion tools/schemapi/schemapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
# class-level _class_is_valid_at_instantiation attribute to False
DEBUG_MODE: bool = True

jsonschema_version_str = importlib_version("jsonschema")


def enable_debug_mode() -> None:
global DEBUG_MODE
Expand Down Expand Up @@ -201,7 +203,6 @@ def _get_json_schema_draft_url(schema: dict) -> str:
def _use_referencing_library() -> bool:
"""In version 4.18.0, the jsonschema package deprecated RefResolver in
favor of the referencing library."""
jsonschema_version_str = importlib_version("jsonschema")
return Version(jsonschema_version_str) >= Version("4.18")


Expand Down
Loading