chore: fixup ruff-mypy CI job due to Ruff change #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found I needed to bump Not sure if that's been an issue for you as well |
|
thanks @dangotbanned - is that commit part of a PR? should I close in favour of that, or just bump ruff here? |
It is part of #3427 but I only added to get CI passing there Probably best to fix it here, since there's another PR active that with the same issue https://github.com/vega/altair/actions/runs/9827488485/job/27130222466?pr=3459 |
|
Thanks for the PR @MarcoGorelli and review @dangotbanned! Tests are happy, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to https://github.com/astral-sh/ruff/pull/12106/files, this is currently failing some CI runs