Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Ignore [arg-type] error in _deduplicate_enum_errors #3475

Merged
merged 3 commits into from
Jul 13, 2024
Merged

fix(typing): Ignore [arg-type] error in _deduplicate_enum_errors #3475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5124ace
fix(typing): Confirm arg type before joining in `_deduplicate_enum_er…
dangotbanned Jul 12, 2024
4d8b28a
revert: undo last commit
dangotbanned Jul 12, 2024
74fb3d7
revert: Ignore type error introduced by `typeshed`
dangotbanned Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion altair/utils/schemapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def _deduplicate_enum_errors(errors: ValidationErrorList) -> ValidationErrorList
# Values (and therefore `validator_value`) of an enum are always arrays,
# see https://json-schema.org/understanding-json-schema/reference/generic.html#enumerated-values
# which is why we can use join below
value_strings = [",".join(err.validator_value) for err in errors]
value_strings = [",".join(err.validator_value) for err in errors] # type: ignore
longest_enums: ValidationErrorList = []
for value_str, err in zip(value_strings, errors):
if not _contained_at_start_of_one_of_other_values(value_str, value_strings):
Expand Down
2 changes: 1 addition & 1 deletion tools/schemapi/schemapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ def _deduplicate_enum_errors(errors: ValidationErrorList) -> ValidationErrorList
# Values (and therefore `validator_value`) of an enum are always arrays,
# see https://json-schema.org/understanding-json-schema/reference/generic.html#enumerated-values
# which is why we can use join below
value_strings = [",".join(err.validator_value) for err in errors]
value_strings = [",".join(err.validator_value) for err in errors] # type: ignore
longest_enums: ValidationErrorList = []
for value_str, err in zip(value_strings, errors):
if not _contained_at_start_of_one_of_other_values(value_str, value_strings):
Expand Down