feat(typing): Generate Literal(s) using "const"
#3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only `"enum"` was considered, meaning `"const"` was represented as `str` - rather than a **single** valid `str` value.
dangotbanned
changed the title
Literal(s) using "const"Literal(s) using "const"
dangotbanned
added a commit
to dangotbanned/altair
that referenced
this pull request
Aug 15, 2024
Still need the changes here prior to that merging. It solves issues in `_config.py` as well. vega#3538
binste
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like #3535, this was another discovery while working through issues in #3536.
Split into another PR as this alters existing generated code.
The core change here is using
Literalfor both (JSON) properties"enum"and"const".In
python's type system, there is no need to distinguish between the two asLiteralcan represent one or more values.