Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump vl-convert-python to 1.7.0 #3633

Merged
merged 1 commit into from
Oct 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Source = "https://github.com/vega/altair"
[project.optional-dependencies]
all = [
"vega_datasets>=0.9.0",
"vl-convert-python>=1.6.0",
"vl-convert-python>=1.7.0",
"pandas>=0.25.3",
"numpy",
"pyarrow>=11",
Expand Down Expand Up @@ -431,7 +431,6 @@ module = [
"vega_datasets.*",
"pyarrow.*",
"yaml.*",
"vl_convert.*",
"pandas.lib.*",
"geopandas.*",
"nbformat.*",
Expand Down
5 changes: 3 additions & 2 deletions tools/generate_schema_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@

if TYPE_CHECKING:
from tools.schemapi.codegen import ArgInfo, AttrGetter
from vl_convert import VegaThemes

SCHEMA_VERSION: Final = "v5.20.1"

Expand Down Expand Up @@ -482,8 +483,8 @@ def download_schemafile(


def _vega_lite_props_only(
themes: dict[str, dict[str, Any]], props: SchemaProperties, /
) -> Iterator[tuple[str, dict[str, Any]]]:
themes: dict[VegaThemes, dict[str, Any]], props: SchemaProperties, /
) -> Iterator[tuple[VegaThemes, dict[str, Any]]]:
"""Removes properties that are allowed in `Vega` but not `Vega-Lite` from theme definitions."""
keep = props.keys()
for name, theme_spec in themes.items():
Expand Down