Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pandas 0 23 #847

Closed
wants to merge 5 commits into from
Closed

Fix pandas 0 23 #847

wants to merge 5 commits into from

Conversation

iliatimofeev
Copy link
Contributor

pandas 0.23 :

pandas.merge() now raises a ValueError when trying to merge on incompatible data types (GH9780)

It cause error in select_detail.py

@jakevdp
Copy link
Collaborator

jakevdp commented May 16, 2018

Hi – Looks like we crossed PRs: I just merged #846

@iliatimofeev
Copy link
Contributor Author

It crashed my #818 on Travis.

@jakevdp
Copy link
Collaborator

jakevdp commented May 16, 2018 •
edited
Loading

Yes, if you rebase to master you'll get the changes I merged in #846 and that should fix the problem in #818.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iliatimofeev @jakevdp