Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vega and Vega-Lite from jsdelivr #336

Open
domoritz opened this issue Apr 4, 2019 · 5 comments
Open

Use Vega and Vega-Lite from jsdelivr #336

domoritz opened this issue Apr 4, 2019 · 5 comments

Comments

@domoritz
Copy link
Member

domoritz commented Apr 4, 2019

This will make it easier to switch versions in the future.

@algomaster99
Copy link
Member

algomaster99 commented Apr 6, 2019

@domoritz When the jsdelivr links are used, how are they imported? JS usually created one global variable to access all the library fucntions but it can't be accessed somehow. One method can be to import it in componentWillMount but that will be highly redundant and inefficient.

@domoritz
Copy link
Member Author

domoritz commented Apr 6, 2019

I think we should do this in webpack somehow or with lazy imports (maybe later).

@siddhant1
Copy link
Member

Loading vega and vega-lite from cdn?

@domoritz
Copy link
Member Author

Yes, in production only, though (or have a somehow the npm version as default so VL and VG devs can use the editor)!

@joelostblom
Copy link

This would be helpful when troubleshooting from altair as well. Now there can be a difference between the version used by altair to render the spec and the version used when clicking "show in vega editor", which can make it confusing to troubleshoot. Example here related to vega/vega-lite#9078:

vlvfatl-oddity-2023-09-04_09.37.00.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants