-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouped density estimates are not computed/rendered correctly #381
Comments
woah, that's weird. Thanks for the report. VegaFusion doesn't perform the density transform itself yet, so I'm guessing it's messing up the order somewhere. |
Huh, I'm actually seeing this behavior without VegaFusion as well. Here's the Vega-Lite spec that Altair 5.1.1 is producing: Open the Chart in the Vega Editor Could you share the Vega-Lite produced in the working case for you? |
Reported, with proposed fix, in vega/vega-lite#9078. I think Vega-Lite needs to specify |
I was so perplexed initially by seeing that it didn't work in VL, but now I know what happened. The regression seem to have been introduced after VL 5.8, so it works fine in altair 5.0.1. Our docker container has 5.0.1 installed so I launched JupyterLab and ran it with this version first. Then realized I should use Altair 5.1.1, so I reinstalled it in the notebook and restarted the kernel but not the notebook itself, so all the specs were still evaluated using altair 5.0.1 and VL 5.8 when using the default renderer; it seems like the vegafusion renderer will correctly detect the updated altair and use the later version but the notebook will not hot reload the VL version. This leads to really confusing behavior as you can see in the video I posted here vega/editor#336 (comment) Tracking that here vega/altair#3183 and I think we can close this issue as vegafusion has not part to play in this. |
But new Python functionality does work? Like Really confusing.. I thought I find out in the previous time this issue was discussed that the newest version of Vega-Lite is loaded and then also will be used for defined altair visualizations in other open notebooks (within the same JupyterLab session). But the behavior here seems different as the first cached JavaScript (?) package of Vega-lite is not renewed when a newer Vega-lite JS is referenced. |
Hmm, I don't think that is the case. I ran the notebook once with the old version, pip installed the new version in the notebook and restarted the kernel. See this video (I'm at a super slow internet right now which is why things take so long): alt-vl-reload-2023-09-04_11.29.15.mp4 |
This chart works fine in altair:
But after enabling the vegafusion data transformer, the grouping is messed up:
The appearance of the issue is similar to what was reported in vega/vega-lite#8049, but setting
steps
explicitly does not seem to fix this bug.The text was updated successfully, but these errors were encountered: