Pandas update 1.5 #463
Merged
Pandas update 1.5 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you update the screenshots? |
|
Thank you |
|
The Galata test is done by comparing screenshots which can sometimes lead
to false positives (for example, a font has changed as a result of a widget
or library upgrade etc.).
Whenever the test fails (as here
https://github.com/vega/ipyvega/actions/runs/4195915036) the generated
images that differ from the reference images are downloadable in the
Artifact section (at the bottom of the page) in the cell-artifact archive.
If after examination these artifacts are considered to be correct (i.e. the
test failure was a false positive or reference images were missing) they
can be used to update references in ui-tests/reference-output/screenshots/.
I prefer to update references this way rather than generating them on my
laptop in order to avoid another potential false positive.
NB: The galata configuration provides an option for a greater tolerance in
the comparison of images but I prefer not to use it for the moment.
Le jeu. 16 févr. 2023 à 18:45, Dominik Moritz ***@***.***> a
écrit :
… How do you update the screenshots?
—
Reply to this email directly, view it on GitHub
<#463 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5QJH25HGDCO7KNXMQX2BLWXZRUVANCNFSM6AAAAAAU6L4OYA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ah? That's great to know. Can you add a short description to the developer contributing document in this repo so we have this process documented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on dom/pandas-update branch, it updates the screenshots and temporarily silence the warnings in NBTest.ipynb (while waiting the fix in te next release of ipytablewidgets),