You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An implicit assumption of using vega/ts-json-schema-generator is that we need to not add regressions to the vega-lite schemas.
When added capabilities to ts-json-schema-generator, the vega-lite constraint exposes corner cases that one is forced to add code to handle.
Due to the complexity of the Vega type-system, it is difficult and sometimes impossible to create minimal tests that exercise such code, ultimately causing degradation of test coverage and causing the CI system to fail.
An automated test would make this dependency explicit, making it easier to ensure coverage.
The text was updated successfully, but these errors were encountered:
An implicit assumption of using vega/ts-json-schema-generator is that we need to not add regressions to the
vega-lite
schemas.When added capabilities to
ts-json-schema-generator
, thevega-lite
constraint exposes corner cases that one is forced to add code to handle.Due to the complexity of the Vega type-system, it is difficult and sometimes impossible to create minimal tests that exercise such code, ultimately causing degradation of test coverage and causing the CI system to fail.
An automated test would make this dependency explicit, making it easier to ensure coverage.
The text was updated successfully, but these errors were encountered: