Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to ensure compatibility with vega-lite TopLevelSpec schema #671

Closed
sramam opened this issue Feb 20, 2021 · 1 comment
Closed

Comments

@sramam
Copy link
Contributor

sramam commented Feb 20, 2021

An implicit assumption of using vega/ts-json-schema-generator is that we need to not add regressions to the vega-lite schemas.

When added capabilities to ts-json-schema-generator, the vega-lite constraint exposes corner cases that one is forced to add code to handle.

Due to the complexity of the Vega type-system, it is difficult and sometimes impossible to create minimal tests that exercise such code, ultimately causing degradation of test coverage and causing the CI system to fail.

An automated test would make this dependency explicit, making it easier to ensure coverage.

@domoritz
Copy link
Member

Done in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants