Tackle multiple instances of a TypeName within a schema

[sramam]

This is an implementation for resolving #666, valid TypeScript programs that the schema-generator cannot handle due to "multiple-instances" in schema error.

[lgtm-com]

This pull request introduces 1 alert when merging 9b34f66 into 6c6f9c9 - view on LGTM.com

new alerts:

• 1 for Unreachable statement

[sramam]

@domoritz, I realize my PRs have probably disrupted your week. This is the last one I promise.

There is still a failing test case - related to the def- prefix attached to DefinitionTypes.
I'm working on that, but the rest of the change should be reviewable for substance - not form.

I'd appreciate your time in reviewing both the issue #666 and this change and providing directional guidance.

[lgtm-com]

This pull request introduces 3 alerts when merging fa9b8b5 into ed725fc - view on LGTM.com

new alerts:

• 3 for Unused variable, import, function or class

[sramam]

@domoritz, this change should be good to go

• all test cases pass,
• no regressions are added to vega-lite.

Coverage does fall. #671/#672 is an attempt to tackle some of that.

[domoritz]

Thank you for the Pull request. It looks like it was a lot of work so I appreciate the work you have done. Unfortunately, I am a bit overwhelmed by the size of the changes. Is there any way to break this up, reduce the complexity or at least increase test coverage?

One change I can see for example is to make srcFileName a property of base type and in the derived classes set it in super. Then you would definitely have better test coverage already since a lot of the untested code is in getSrcFileName.

[sramam]

Thanks for taking the time to review.

I've had to move on to other things - so I might be a bit slow to get this done.
However I'd like nothing more than not having to maintain this in a fork for my personal use.
So the first chance I get, I will be working on getting this merged.

I like the getSrcFileName idea. While I don't like the large change either, I am a bit skeptical it can be done piecemeal.
That said, I promise to keep an open mind!

[domoritz]

Thanks! I am happy to help with more reviews. I'll mark this pull request as draft for now.

[domoritz]

@sramam can you finish up this pull request?

[sramam]

@sramam can you finish up this pull request?

I haven't found the time to get into making the changes you suggested. The context switch time is much larger for me and this would require a large block of time which has been a hurdle.

It's on my back-burner though - in the sense that I feel guilty not having closed this out. Hopefully soon.

[domoritz]

No need to feel guilty. I appreciate that you want to make the time. Personal care should take priority over this project.