-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli overhaul with oclif #1966
base: next
Are you sure you want to change the base?
Conversation
Actually, there's no way to run these new binaries when there's still an entry to This probably will force us to remove the previous binary entirely and probably release another major version (v3.0.0) |
Since oclif has commands support ( I reduced the cli to only |
https://github.com/intuit/auto has a git check that prevents releasing when there are changed files locally, and as there's no current way to remove that behavior (would need to open a issue first), every time the |
What do you think about Also, I am not a fan of having to type |
|
I think I'd prefer to keep the current name since it's used and I never write it manually anyway. Having the cli name be the same as the package makes it very clear. |
Ok, We could also define
However I'm almost sure I cannot just "transpile" the previous CLI to this new one without any breaking change. Is releasing v3.0.0 a bad thing? it will only consist of argument changes that can be fixed up in ~10s. |
A major release is some work here and then in the repos that use the schema generator. Not a huge deal but we should minimize the changes so I like your proposal. |
This PR adds a new cli under the name of
tjsg
. I kept the previousts-json-schema-generator
intact to keep compatibility with older versions and avoid another breaking release.Also updated readme and set up oclif to automatically update some readme sections to keep up with cli changes.
New --flags were added and some unused ones were removed.
Some outputs:
📦 Published PR as canary version:
2.2.1--canary.1966.fab4d27.0
✨ Test out this PR locally via:
npm install ts-json-schema-generator@2.2.1--canary.1966.fab4d27.0 # or yarn add ts-json-schema-generator@2.2.1--canary.1966.fab4d27.0