Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert back to commons js #1975

Merged
merged 5 commits into from
May 27, 2024
Merged

fix: revert back to commons js #1975

merged 5 commits into from
May 27, 2024

Conversation

arthurfiorette
Copy link
Collaborator

@arthurfiorette arthurfiorette commented May 27, 2024

📦 Published PR as canary version: 2.3.0--canary.1975.2880903.0

✨ Test out this PR locally via:

npm install ts-json-schema-generator@2.3.0--canary.1975.2880903.0
# or 
yarn add ts-json-schema-generator@2.3.0--canary.1975.2880903.0

Version

Published prerelease version: v2.3.0-next.2

Changelog

🚀 Enhancement

🔩 Dependency Updates

Authors: 2

@arthurfiorette arthurfiorette linked an issue May 27, 2024 that may be closed by this pull request
@arthurfiorette arthurfiorette self-assigned this May 27, 2024
@arthurfiorette arthurfiorette changed the title fix: Revert back to commons js fix: revert back to commons js May 27, 2024
@arthurfiorette
Copy link
Collaborator Author

Hey @sacummings91 and @navalex could you guys try out 2.2.1--canary.1975.4fce06c.0?

@arthurfiorette
Copy link
Collaborator Author

@domoritz ready for review

eslint.config.js Outdated Show resolved Hide resolved
@arthurfiorette arthurfiorette enabled auto-merge (squash) May 27, 2024 19:38
@arthurfiorette arthurfiorette enabled auto-merge (squash) May 27, 2024 19:40
@arthurfiorette arthurfiorette merged commit 2880903 into next May 27, 2024
3 checks passed
@arthurfiorette arthurfiorette deleted the arthur/cjs-tests branch May 27, 2024 19:46
@navalex
Copy link

navalex commented May 29, 2024

Hey @sacummings91 and @navalex could you guys try out 2.2.1--canary.1975.4fce06c.0?

Done, reply in my issue

@arthurfiorette
Copy link
Collaborator Author

The Commonsjs bundle worked. Your issue has another error now.

Copy link

github-actions bot commented Jun 5, 2024

🚀 PR was released in v2.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CJS imports
3 participants