fix: add NoInfer to IntrinsicNodeParser #2133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurfiorette
requested changes
Dec 13, 2024
| @@ -12,6 +12,7 @@ export const intrinsicMethods: Record<string, ((v: string) => string) | undefine | |||
| Lowercase: (v) => v.toLowerCase(), | |||
| Capitalize: (v) => v[0].toUpperCase() + v.slice(1), | |||
| Uncapitalize: (v) => v[0].toLowerCase() + v.slice(1), | |||
| NoInfer: (v) => v, | |||
|
Ah totally missed that the tests are in a separate folder, I'll look at it |
arthurfiorette
requested changes
Dec 13, 2024
| @@ -4,11 +4,13 @@ type ResultUpper = Uppercase<Result>; | |||
| type ResultLower = Lowercase<ResultUpper>; | |||
| type ResultCapitalize = Capitalize<Result>; | |||
| type ResultUncapitalize = Uncapitalize<ResultCapitalize>; | |||
| type ResultNoInfer = NoInfer<Result>; | |||
There was a problem hiding this comment.
I'm pretty sure this isn't how NoInfer is intended to be used and is a flaky test since all other intrinsic types are string-dependent and NoInfer might not be.
Please create a separate test with a code like:
// (I wrote this out of my head)
function test<T>(value: NoInfer<T>): T { return value }
// create a function with type constraints as well (test<T extends something>())
export const MyObject = {
str: test('asd'),
// more samples with objects, type references, and so on...
}There was a problem hiding this comment.
but thanks for working in this <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2132