Add void type

[bollwyvl]

Thanks for the great tool!

This adds a VoidType(|Formatter|Parser).

Some background:

I'm looking into microsoft/language-server-protocol#67, basically reconciling the reference implementation types with the (separately maintained) specification. The good news: tsjsg handles the protocol.ts without complaint. Hooray 🎉!

But... I've been running into a fair number of things that aren't getting pulled in to fully describe/validate what's in the markdown spec, and am having to expand my --paths, thereby encountering new issues. I assume it's failing after the first problem, so this is no doubt going to be one of those epic yak shaves.

The very first one is an interesting use of void:

export namespace ConfigurationRequest {
	export const type = new RequestType<ConfigurationParams & PartialResultParams, any[], void, void>('workspace/configuration');
	export type HandlerSignature = RequestHandler<ConfigurationParams, any[], void>;
	export type MiddlewareSignature = (params: ConfigurationParams, token: CancellationToken, next: HandlerSignature) => HandlerResult<any[], void>;
}

which yields

Error: Unknown node "void" (ts.SyntaxKind = 107) at .../vscode-languageserver-node/protocol/src/protocol.configuration.ts(37,75)

This fixes the void problem (hooray)...

Yak shave n+1:

...revealing the next thing:

Error: Unknown type "function"

Onward!

note: i got this when trying to lint:

yarn run v1.15.2
$ eslint '{src,test,factory}/**/*.ts'

Oops! Something went wrong! :(

ESLint: 6.5.1.

ESLint couldn't find the config "@satazor/eslint-config/es5" to extend from. Please check that the name of the config is correct.

The config "@satazor/eslint-config/es5" was referenced from the config file in "/home/weg/Documents/projects/ts-json-schema-generator/envs/lsp-json-schema/lib/node_modules/npm/node_modules/err-code/.eslintrc.json".

hopefully it all works out!

[domoritz]

This is great. Thank you for the PR. Just one comment.

[domoritz]

Why is this number, not void?

[bollwyvl]

.. apparently, because I copy and paste poorly!

Fixing, testing locally!

The test copy pasta raises some interesting questions: perhaps an interesting place to use both mutation and property testing>

[domoritz]

Add a test case that checks the pair of ts and schema file. There is already a file that runs test cases. We don’t pick up just the files.

[bollwyvl]

Added generic-void to the tests, looks okay locally.

Also I noticed that coverage isn't getting picked up:

==> Uploading reports
    url: https://codecov.io
    query: branch=pull%2F242&commit=0edc3e90786199baf8c71b284599d4c94ec4eaf7&build=189&build_url=&name=189&tag=&slug=vega%2Fts-json-schema-generator&service=circleci&flags=&pr=242&job=0
    -> Pinging Codecov
https://codecov.io/upload/v4?package=bash-8a28df4&token=secret&branch=pull%2F242&commit=0edc3e90786199baf8c71b284599d4c94ec4eaf7&build=189&build_url=&name=189&tag=&slug=vega%2Fts-json-schema-generator&service=circleci&flags=&pr=242&job=0
HTTP 400
Provided token is not a UUID.

I wonder if that would that have caught it?

[domoritz]

The coverage would maybe have caught it. I should see what's going wrong. Thank you for adding the test.

[domoritz]

Hmm, the coverage upload works on my branches: https://app.circleci.com/jobs/github/vega/ts-json-schema-generator/192.

[domoritz]

Ahh, @codecov doesn't work well with circleci. They don't allow coverage unless you run on the same fork.

[bollwyvl]

No doubt I can't access the token or something. No worries! I haven't had much time to keep working on the actual problem (lsp schema)... No doubt I'll uncover more things when I do. A thing they do a lot is define an enum, and then a separate type that shares there same values. Kind of maddening, from a schema point of view, but I guess it keeps people honest.

…

On Wed, Oct 23, 2019, 18:51 Dominik Moritz ***@***.***> wrote: Hmm, the coverage upload works on my branches: https://app.circleci.com/jobs/github/vega/ts-json-schema-generator/192. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#242?email_source=notifications&email_token=AAALCRB2YMHDPMS2K4HBS3LQQDIOLA5CNFSM4JCSCBT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECDD5LI#issuecomment-545668781>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRBKGA4GUNQRXNKENODQQDIOLANCNFSM4JCSCBTQ> .

[domoritz]

Thank you!

[bollwyvl]

Thanks again for the great tool!

Over on The Quest for LSP, I finally made some progress, and am now generating 227 (minus 51 i made up, and one that wasn't exported) types, including voids!. This (almost) covers the Request side of the the house with just a few remaining gotchas. Hopefully I'll get to start on the Responses soon, i'm sensing some typeofs will be needed, which doesn't sound very fun...

[bollwyvl]

Over on The Quest for LSP

Actually, that worked out much better than I could have hoped, and is basically done: thanks for making it possible!

https://gist.github.com/bollwyvl/7a128978b8ae89ab02bbd5b84d07a4b7

There's a nagging issue, no doubt with my kludgy generated typescript around a oneOf/anyOf I'm not asking for yet, but otherwise looking pretty good!