Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce CRLF-inflated Resource.bytes size #653

Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix: reduce CRLF-inflated Resource.bytes size #653

merged 1 commit into from
Dec 21, 2024
+54 −53

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Dec 21, 2024 •
edited
Loading

Resolves:

Description

It turns out os.stat_result.st_size wasn't the issue.

Essentially, traces back to configuring-git-to-handle-line-endings

I forgot that I set --global core.autocrlf true, which I'd overriden in altair

I've now forced that to false everywhere I could locally, and added a .gitattributes in case this comes up with another contributor in the future

@dangotbanned dangotbanned marked this pull request as ready for review December 21, 2024 16:07
@dangotbanned dangotbanned merged commit 2f1c39f into main Dec 21, 2024
3 checks passed
@dangotbanned dangotbanned deleted the fix-crlf-file-size branch December 21, 2024 16:07
@dangotbanned dangotbanned changed the title fix: fix CRLF-inflated Resource.bytes size fix: reduce CRLF-inflated Resource.bytes size Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dangotbanned