-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping support for format and title in axis and legends for Vega Lite 3.0 #4057
Comments
FYI, currently there is only For |
Doing so might be useful if we want to enable parts of axis to show both top and bottom/left and right by making the |
I'm not so sure about positioning titles that way but do you agree that we should change |
Changing the axis/legend |
I don't know if we should really introduce this breaking changes given it's probably already widely used. In fact, we even use While we can of course go update the online gallery for making data visual, it seems like we don't gain much from this breaking change -- maybe a better thing to do is fix the bug in tooltip encoding to read axis/legend/header title too? |
I think it's better to have only one way to set the title, rather than four (title, axis title, legend title, header title). We only used |
If you're adding a pre-processor, then it's not changing the behavior then. Just how we implement it. |
Well, and I'd not document it officially. Just to not annoy users too much. |
I don't see how it's more annoying for users. Having document that doesn't match behavior is weird. (I do agree that having two ways of doing things is actually more annoying for us who maintain the projects.) Thinking more, it's also kinda weird that they can specify If we start from scratch, I can see the argument for having only one of this. But at this point, removing it isn't really beneficial and will only break things and annoy users. So let's only discuss how we gonna refactor this internal and prevent future errors like we have with tooltip. I think we should think about fieldDef.title as a shorthand and axis/legend/header.title as the full form (as we will merge |
No, you could have a title that is used for tooltips but not for the axis. Or it's only visible if you use the channel for a legend. |
I agree with this part.
Not sure how important is this case, I can see your point.
I think 2) is way less work and doesn't make the code more complicated. (It's complicated, but I don't see 1) being simpler.) |
We fixed the tooltip bug in #4076 and we agreed in person that we should not change the syntax, so let's close this. |
Proposed by @domoritz. Allowing users to to define format and title in two locations seems confusing.
One example of potentially confusing behavior is that when generating tool tips we use the encoding title and format and not the axis title and format which might not be straight forward for users.
The text was updated successfully, but these errors were encountered: