Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display title when set in config.axisX/axisY.title #9541

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarcBaeuerle
Copy link
Contributor

@MarcBaeuerle MarcBaeuerle commented Feb 20, 2025

potentially closes #9429

This fixes the compilation process from vega lite to vega by accounting for the title property inside the config.
@domoritz suggested removing support for setting the axis title inside the config entirely, but due to the consensus in #4057 I chose this solution instead.

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully

@MarcBaeuerle MarcBaeuerle requested a review from a team as a code owner February 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"config": {"axisX": {"title": "foo"}} removes title
1 participant