fix: avoid repetitive labels by using tickMinStep #8872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
Apr 29, 2023
domoritz
approved these changes
May 1, 2023
| @@ -74,6 +74,9 @@ | |||
| "gridScale": "y", | |||
| "grid": true, | |||
| "tickCount": {"signal": "ceil(width/40)"}, | |||
| "tickMinStep": { | |||
| "signal": "datetime(2001, 1, 1, 0, 0, 0, 0) - datetime(2001, 0, 1, 0, 0, 0, 0)" | |||
There was a problem hiding this comment.
Do you think we could precompute this so that we don't need a signal here?
There was a problem hiding this comment.
I prefer using signal given it's not that expensive to calculate once, but it's gonna be more readable than some magic constant that presents duration timestamps.
5 tasks
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8867 - Avoid repetitive labels by using tickMinStep
(replacing #8868 to use tickMinStep as @domoritz suggested)