-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Configure deployment previews with Vega Editor #9294
Conversation
automatic lockfile upgrade
Deploying vega-lite with Cloudflare Pages
|
What's the difference between preview and branch preview? |
Since we know that this is now working, I'm going to remove the "console.log" commit so the linter won't be bothered. |
…site" This reverts commit f81b471.
I see. So the branch url will always give me the latest while the commit will always be the same snapshot. Looks good. |
Apologies for the reping @domoritz - just had to move the PR out of draft. I haven't heard back from the Cloudflare team RE: open source sponsorship, but I'm OK with just using my plan's builds for the month so we get a napkin math sense of how many builds per month we'll need for our usual contribution volume. |
Will this trigger automatically on each PR and subsequent commits? I can imagine a PR on the docs don't require this preview. Would it be an idea to trigger it manually on request? |
I think you switched this over, right @hydrosquall? Can we exclude Either way, for now I think we should merge this to see how it works out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Yes, good point. I can also ignore builds that only change files under a specific directory. I could set up a rule to ignore changes to the
I don't see a straightforward way to do that yet. For now it'll just build on every commit.
Switching it over this evening! I'll have it exclude the |
Motivation
Changes
vega/editor
without running theprepare
script. (The CI device doesn't have rsync installed)./
as the base URL (previously it was erroring due to thinking it was under the/editor
subdomain). Technically this is an abstraction leak but fixing it would involve modifying the vega/editor repo too and I'd like to contain this change to 1 repo if possible.Testing
Notes
cameron.yick/*
branches have the previews since the build script is WIP. It's using my personal Cloudflare account for testing. I'll open it up to all (non dependabot/*) PRs this change is confirmed.