Fix 1.1.0rc4 hang in pre_transform_dataset #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around #268 by copying the input pyarrow table through the IPC bytes representations. It also allows us to properly hash the input PyArrow table, which allows the cache to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
This fixes / works around the hang reported in #268. I don't understand the full cause, but it's mitigated by copying the input Arrow table through the IPC format. We lose zero copy, but it should still be an improvement over prior versions as the IPC clone is happening all in Rust. Also important, this approach allows us to compute an accurate hash for the input table (rather than using the Python
idof the PyArrow table), so it improves cacheing.