Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Expose vendored vega version string #191

Closed
dangotbanned opened this issue Sep 30, 2024 · 1 comment · Fixed by #194
Closed

python: Expose vendored vega version string #191

dangotbanned opened this issue Sep 30, 2024 · 1 comment · Fixed by #194
Labels
enhancement New feature or request

Comments

@dangotbanned
Copy link
Member

Originally posted by @dangotbanned in review

@mattijn I've settled on the solution here for now:

I'm going to open an issue on https://github.com/vega/vl-convert to see if we can later replace this with a public vl_convert function/attribute.
The result would be the same and depend on the same const, but would be less reliant on the structure of vl-convert-vendor/src/main.rs

@jonmmease I was wondering if you'd be able to expose the version string component ("v5.30.0") of this under the top level vl_convert.___?

const VEGA_PATH: &str = "/pin/vega@v5.30.0-fYDVG3pUN16BiGmbVNdw/mode=imports,min/optimized/vega.js";

The specific use-case here is to ensure we generate the correct alt.expr.___ methods, corresponding to a given vega release.
My first attempt used the dependencies in vega-lite, but this doesn't specify v5.3.0
https://github.com/vega/vega-lite/blob/c7697dc293b606ba60c7e374dbf9a77226f91225/package.json#L137-L138

Related

@jonmmease
Copy link
Collaborator

Hi @dangotbanned, yeah exposing the vendored version numbers makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants