fix: do not try to show milestone if there is none

vegaprotocol · Jan 12, 2024 · 4ec15ff · 4ec15ff
1 parent d570cd3
commit 4ec15ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@vegaprotocol/approbation",
- "version": "4.7.0",
+ "version": "4.7.1",
  "description": "Match Acceptance Criteria Codes with the tests that test them",
  "engine": ">= 18",
  "bin": "./bin/approbation.js",

diff --git a/src/check-references.js b/src/check-references.js
@@ -425,10 +425,15 @@ function checkReferences(specsGlob, testsGlob, categoriesPath, ignoreGlob, featu
  }
 
  if (shouldOutputJenkins) {
- const currentMilestone = totals.pop()
+ const currentMilestone = totals && totals.length > 0 ? totals.pop() : false
+
  const skipCategories = ['Category', 'Specs', 'Acceptable']
  let jenkinsLine = `All ACs: ${Object.entries(categories.pop()).map(([key, value]) => skipCategories.indexOf(key) === -1 ? `*${key}*: ${value}` : '').join(' ').trim()}`
- jenkinsLine += `\r\nCurrent milestone ACs: *${currentMilestone.Milestone}*: ${currentMilestone.Coverage}`
+
+ if (currentMilestone) {
+ jenkinsLine += `\r\nCurrent milestone ACs: *${currentMilestone.Milestone}*: ${currentMilestone.Coverage}`
+ }
+
  fs.writeFileSync(`${outputPath}/jenkins.txt`, jenkinsLine)
  }