-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable running LiqBot #179
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zale144, thanks for the PR. Overal it looks good. Just small changes are required. But you have to publish the bots image.
@@ -189,6 +215,20 @@ func (c *Config) setAbsolutePaths() error { | |||
c.Network.Nodes[idx].DataNodeBinary = dataNodeBinPath | |||
} | |||
|
|||
// Pre start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick: the comment is not really necessary. It is obvious that we set it for PreStart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to be consistent with the comments above
|
||
post_start { | ||
docker_service "liqbot" { | ||
image = "vegaprotocol/liqbot:local" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to publish this image. This would not work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless building it locally :) I wasn't sure if I have access. Will try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zale144 pm me if you want access and I can show you how to publish the image :)
Add an example config files, add volumes for pre/post, small improvement