Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running LiqBot #179

Closed
wants to merge 6 commits into from
Closed

Enable running LiqBot #179

wants to merge 6 commits into from

Conversation

zale144
Copy link

@zale144 zale144 commented Jul 7, 2022

Add an example config files, add volumes for pre/post, small improvement

@zale144 zale144 requested a review from karlem July 7, 2022 21:38
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@karlem karlem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zale144, thanks for the PR. Overal it looks good. Just small changes are required. But you have to publish the bots image.

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@@ -189,6 +215,20 @@ func (c *Config) setAbsolutePaths() error {
c.Network.Nodes[idx].DataNodeBinary = dataNodeBinPath
}

// Pre start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: the comment is not really necessary. It is obvious that we set it for PreStart

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to be consistent with the comments above

net_confs/config_bot.hcl Outdated Show resolved Hide resolved

post_start {
docker_service "liqbot" {
image = "vegaprotocol/liqbot:local"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to publish this image. This would not work :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless building it locally :) I wasn't sure if I have access. Will try

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zale144 pm me if you want access and I can show you how to publish the image :)

@gordsport gordsport linked an issue Aug 10, 2022 that may be closed by this pull request
@zale144 zale144 closed this Feb 1, 2023
@ValentinTrinque ValentinTrinque deleted the run-liqbot branch July 19, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants