Use new sys.thread package when possible on haxe 4 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Aidan, For the PR to be accepted please fix the syntax error and squash your commits. Thank you! Seb |
simplified threads conditional compilation Updated RLock to use sys.thread.Mutex when on haxe 4 Updated queue to use sys.thread.Deque when on haxe 4 Updated #if syntax to make older haxe versions happy Simplified java and haxe version conditionals
|
Hi (and sorry for the late reply), was meaning to sort out the issues over the weekend but forgot! I've fixed up what appears to be the last few remaining issues and squashed everything down to a single commit, so once this CI round is done hopefully it should be good to go. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Haxe 4.0.0-rc.2 introduces the
sys.threadpackage to replace the individual threading classes for interp, neko, cpp, hl, and java and I've gone through and made it use those classes when possible.Hopefully I've found all the important conditional compilation sections, it's working for my use on haxe 4 but I don't use all the targets, hopefully the ci will catch any issues!