Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Updated Supported MacOS versions #891

Merged
merged 24 commits into from
Dec 25, 2024
Merged

Maintenance: Updated Supported MacOS versions #891

merged 24 commits into from
Dec 25, 2024

Conversation

BenjamenMeyer
Copy link
Member

Code Changes:

@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Oct 5, 2024
@BenjamenMeyer BenjamenMeyer requested review from royfalk, Loki1950 and a team October 5, 2024 16:50
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 5, 2024
royfalk
royfalk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even support ARM architecture? I have an M1 I can try and test on, though it might take me a while to do it.

@BenjamenMeyer
Copy link
Member Author

Do we even support ARM architecture? I have an M1 I can try and test on, though it might take me a while to do it.

We haven't setup runners to try. But all new Mac's will be ARM-based so it's be good to find out

@BenjamenMeyer BenjamenMeyer mentioned this pull request Dec 11, 2024
Closed
@BenjamenMeyer
Refactor MacOS CI Builds
336a86e 
- move the bootstrapping of MacOS into a script so it's easier to
  see what is going on and customize it for the various MacOS
  releases
@BenjamenMeyer
Checkout code before relying on what's in the repo
030e60c
@BenjamenMeyer
Bash via env bash
fcb2822
@BenjamenMeyer
proper OS matching
40dbdea
@royfalk
Copy link
Contributor

royfalk commented Dec 11, 2024

Two comments:

  1. We need to deprecate version 12. It's EoL.
  2. M1 was released in 2020. Officially supporting Mac Intel is a waste of time.
  3. Until Unless we can test on Apple silicon and check the game runs, there's no point in supporting a mac port.

@BenjamenMeyer
Bug Fix (Mac): Homebrew installation
e707379 
- Homebrew is utilized for dependencies on MacOS. Update the Path
  and build variables to point at/include the Homebrew environments
- Note which versions of MacOS that are no longer supported and
  terminate the script early so the build pipeline will fail too

NOTE: The previous method used some symlinks to update the OpenGL
  install; however, it's installed under Homebrew now so including
  Homebrew should fix things better and more reliably.
@BenjamenMeyer
Copy link
Member Author

@royfalk so we started supporting building for MacOS on 0.9.x; we were going to target having an official installer for MacOS with 0.10.x. However, I do agree that we need to scale it back a little. For that - we should probably continue with having a build available so the community has something to test. Let's see how this PR goes and if we can get builds working. If so, then we'll just keep it at that until the community can test more and let us know where bugs are. If it does prove to be too hard to keep it going we'll drop the build support until someone comes along to specifically maintain it too. Fair?

@stephengtuggy
Copy link
Contributor

@BenjamenMeyer yeah, the Python versions on macOS are a mess. I've had so much trouble with those in the past.

Good luck. Hopefully you can get it to work.

It's probably better to use whatever version of Python is already installed on the Mac runner machine (if any), rather than try to force-install a specific version all the time. It looks like that might be what you're trying to do with the last few commits.

@stephengtuggy
Copy link
Contributor

Alternatively, perhaps do a Homebrew keg-only install of the desired Python version, and use that. That way you're not messing up the macOS system-wide installs for other users of the same runner.

@BenjamenMeyer
Copy link
Member Author

BenjamenMeyer commented Dec 15, 2024 •
edited
Loading

@stephengtuggy thanks for the insight. Yeah, it's a matter of which version of Python Boost links to. And I think it's mixed or something. Not sure. I don't have a Mac myself I can play with locally to test so having to debug via the runners.

More trying to set the environment right so Cmake will use the right set of libraries. homebrew python3 is newer than what homebrew boost-python links with and it's causing an issue from what I can tell.

@royfalk
Copy link
Contributor

royfalk commented Dec 16, 2024

I just reviewed the PR again and it still looks good (except it fails).
Let me know if you need some help with it.

@stephengtuggy
Copy link
Contributor

I seem to be making some headway, over on the 0.9.x side of things! My in-progress changes are here .

@stephengtuggy
Copy link
Contributor

I seem to be making some headway, over on the 0.9.x side of things! My in-progress changes are here .

Pull Request submitted for 0.9.x! #932

@BenjamenMeyer
Peer Review
05c71b8 
Thanks @stephengtuggy for pointing out the Python GHA and
a couple other settings that may help out.
@BenjamenMeyer BenjamenMeyer mentioned this pull request Dec 22, 2024
Closed
2 tasks
@royfalk royfalk mentioned this pull request Dec 24, 2024
Merged
1 task
@BenjamenMeyer
Peer Review
83ec5d5 
- For MacOS set the CMake Find Framework to Last
- For MacOS set the more specific Python Version; it's that for
  all the OS versions anyway
@BenjamenMeyer
Bug Fix
29245d9 
1. getting the following error:
"Fatal Python error: init_fs_encoding: failed to get the Python codec of
the filesystem encoding"
which apparently means the PYTHONHOME and PYTHONPATH do not need to be
set.
2. Reverting to allow Homebrew to tell where the Python build is
@BenjamenMeyer
Bug Fix: Update to C++ 14
47c2808
@BenjamenMeyer
Cleanup
ee1c18c 
- cleanup the scripts a little to get rid of some stuff from debugging
  the process
- drop MacOS 14 support for now (and by extension Mac OS 15) as it
  is on the M1+ ARM processor set and there seems to be some linker
  issues.
@BenjamenMeyer BenjamenMeyer merged commit 0929b86 into vegastrike:master Dec 25, 2024
33 checks passed
@BenjamenMeyer BenjamenMeyer mentioned this pull request Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengtuggy stephengtuggy stephengtuggy left review comments

@royfalk royfalk royfalk approved these changes

@Loki1950 Loki1950 Awaiting requested review from Loki1950

Assignees

@BenjamenMeyer BenjamenMeyer

Labels
CI/CD
Projects
None yet
Milestone
0.10.x
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjamenMeyer @royfalk @stephengtuggy