Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Vega Strike 0.9.x over to use boost::program_options #967

Merged
merged 29 commits into from
Jan 11, 2025
Merged

Switch Vega Strike 0.9.x over to use boost::program_options #967

merged 29 commits into from
Jan 11, 2025

Conversation

stephengtuggy
Copy link
Contributor

@stephengtuggy stephengtuggy commented Jan 7, 2025 •
edited
Loading

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Port OndraK's excellent boost::program_options work over to the 0.9.x branch
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy stephengtuggy added this to the 0.9.x milestone Jan 7, 2025
@stephengtuggy stephengtuggy self-assigned this Jan 7, 2025
@stephengtuggy
Switch vegasettings over to use boost::program_options as well
93bab0e
@stephengtuggy
macos-ci.yml: Set up multiple Python versions side by side
7f4cb78
@stephengtuggy
macos-release.yml: Set up multiple Python versions side by side
75d65e2
@stephengtuggy
macos-ci.yml: Reverse the order of the two Python versions
527ab8e
@stephengtuggy
More on macos-*.yml x2
961ae08
@stephengtuggy
ani_texture.h: Fix some annoying, repetitive warnings
f08ca31
@stephengtuggy
More on macos-*.yml x2: Don't update machine-wide environment variabl…
7d31b4f 
…es for Python; instead use output from setup-python action directly in build step
@stephengtuggy
macos-ci.yml: Move python version to the matrix
4a20c71
@stephengtuggy
macos-ci.yml: ...
e09b202
@stephengtuggy
macos-ci.yml: Add AppleClang as one of the compilers to build with
e95d68d
@stephengtuggy
macos-ci.yml, CMakePresets.json: Set more Python search parameters
121ce24
@stephengtuggy
macos-ci.yml, CMakePresets.json: Set more Python search parameters
b9b2097
@stephengtuggy
...
b006623
@stephengtuggy
...
34c1857
@stephengtuggy
engine/setup/CMakeLists.txt: ...
7cd6767
@stephengtuggy
Merge branch '0.9.x' into boost_program_options_0.9.x
0dc4f23
@stephengtuggy
engine/setup/CMakeLists.txt: having a TARGET_LINK_LIBRARIES clause mi…
392bb60 
…ght help, heh
@stephengtuggy
CMakePresets.json, macos-ci.yml, macos-release.yml: Undo a lot of my …
80383f0 
…macOS related changes, since they didn't work
@stephengtuggy
engine/setup/CMakeLists.txt: Tabs to spaces
f9b0e33
@stephengtuggy stephengtuggy marked this pull request as ready for review January 8, 2025 13:44
BenjamenMeyer
BenjamenMeyer approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tried it but LGTM

@stephengtuggy stephengtuggy merged commit 27ed843 into vegastrike:0.9.x Jan 11, 2025
24 checks passed
@stephengtuggy stephengtuggy deleted the boost_program_options_0.9.x branch January 11, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

@royfalk royfalk Awaiting requested review from royfalk

Assignees

@stephengtuggy stephengtuggy

Labels
enhancement
Projects
None yet
Milestone
0.9.x
Development

Successfully merging this pull request may close these issues.
2 participants
@stephengtuggy @BenjamenMeyer