Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CRAN issues #159

Merged
merged 5 commits into from
Mar 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ revdep/library
revdep/checks.noindex
revdep/library.noindex
revdep/data.sqlite
venv/
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: altair
Version: 4.2.1.9000
Version: 4.2.1.9001
Title: Interface to 'Altair'
Description: Interface to 'Altair' <https://altair-viz.github.io>, which itself
is a 'Python' interface to 'Vega-Lite' <https://vega.github.io/vega-lite/>.
Expand All @@ -10,7 +10,7 @@ Authors@R: c(
person(
given = "Ian",
family = "Lyttle",
email = "ian.lyttle@se.com",
email = "ijlyttle@me.com",
role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-9962-4849")
),
Expand Down Expand Up @@ -62,4 +62,4 @@ Suggests:
png,
fs
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.2
RoxygenNote: 7.2.3
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# altair (development version)

* Update signatures of `repr_text()` and `repr_vegalite4()` to align with signatures of their generics. (#158)

# altair 4.2.1

* Upgrade to [vegawidget](https://vegawidget.github.io/vegawidget/) 0.4.1. (#150, #154)
Expand Down
4 changes: 2 additions & 2 deletions R/utils-jupyterlab.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ py_mimebundle <- function(obj) {
#' @importFrom repr repr_text
#' @export
#'
repr_text.altair.vegalite.v4.api.TopLevelMixin <- function(obj) {
repr_text.altair.vegalite.v4.api.TopLevelMixin <- function(obj, ...) {
py_mimebundle(obj)$`text/plain`
}

Expand All @@ -31,6 +31,6 @@ repr_text.altair.vegalite.v4.api.TopLevelMixin <- function(obj) {
#' @importFrom repr repr_vegalite4
#' @export
#'
repr_vegalite4.altair.vegalite.v4.api.TopLevelMixin <- function(obj) {
repr_vegalite4.altair.vegalite.v4.api.TopLevelMixin <- function(obj, ...) {
py_mimebundle(obj)$`application/vnd.vegalite.v4+json`
}
2 changes: 1 addition & 1 deletion man/repr_text.altair.vegalite.v4.api.TopLevelMixin.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/repr_vegalite4.altair.vegalite.v4.api.TopLevelMixin.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions man/vegawidgetOutput.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.